[ovs-dev] [PATCH v4 4/7] dpdk: enable cpu feature detection.

Van Haaren, Harry harry.van.haaren at intel.com
Tue Jun 30 10:00:46 UTC 2020


> -----Original Message-----
> From: William Tu <u9012063 at gmail.com>
> Sent: Saturday, June 27, 2020 7:27 PM
> To: Van Haaren, Harry <harry.van.haaren at intel.com>
> Cc: ovs-dev <ovs-dev at openvswitch.org>; Stokes, Ian <ian.stokes at intel.com>;
> Ilya Maximets <i.maximets at ovn.org>; Federico Iezzi <fiezzi at redhat.com>
> Subject: Re: [PATCH v4 4/7] dpdk: enable cpu feature detection.
> 
> On Thu, Jun 18, 2020 at 9:53 AM Harry van Haaren
> <harry.van.haaren at intel.com> wrote:
> >
> > This commit implements a method to retrieve the CPU ISA capabilities.
> > These ISA capabilities can be used in OVS to at runtime select a function
> > implementation to make the best use of the available ISA on the CPU.
> >
> > Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
> >
> > ---
> >
> > v4:
> > - Improve commit title and message
> > ---
> >  lib/dpdk-stub.c | 13 +++++++++++++
> >  lib/dpdk.c      | 27 +++++++++++++++++++++++++++
> >  lib/dpdk.h      |  2 ++
> >  3 files changed, 42 insertions(+)
> >
> > diff --git a/lib/dpdk-stub.c b/lib/dpdk-stub.c
> > index c332c217c..9935f3d2b 100644
> > --- a/lib/dpdk-stub.c
> > +++ b/lib/dpdk-stub.c
> > @@ -79,6 +79,19 @@ print_dpdk_version(void)
> >  {
> >  }
> >
> > +int
> > +dpdk_get_cpu_has_isa(const char *arch OVS_UNUSED,
> > +                     const char *feature OVS_UNUSED)
> 
> should we just have bool as a return type?

Sure yes, will fix.

> > +{
> > +    static struct ovsthread_once once = OVSTHREAD_ONCE_INITIALIZER;
> > +    if (ovsthread_once_start(&once)) {
> > +        VLOG_ERR("DPDK not supported in this version of Open vSwitch, "
> > +                 "cannot use CPU flag based optimizations");
> > +        ovsthread_once_done(&once);
> 
> How about using VLOG_ERR_ONCE()?

Ah nice - indeed manually doing the ovsthread_once_start() etc felt a little clunky.
Updated in v5.

> > +    }
> > +    return 0;
> and just return false here.

Yep, will do.

> The rest looks good to me, thanks
> 
> William

Cheers!


More information about the dev mailing list