[ovs-dev] [PATCH ovn v2] Split SB Port_Group per datapath.

[Dumitru Ceara]

On 6/30/20 2:08 PM, Mark Michelson wrote:
> On 6/30/20 4:42 AM, Numan Siddique wrote:
>> On Mon, Jun 29, 2020 at 8:55 PM Dumitru Ceara <dceara at redhat.com> wrote:
>>
>>> In order to avoid ovn-controller reinstalling all logical flows that
>>> refer a port_group when some ports are added/removed from the port group
>>> we now change the way ovn-northd populates the Southbound DB Port_Group
>>> table.
>>>
>>> Instead of copying NB.Port_Group.name to SB.Port_Group.name we now
>>> create one SB.Port_Group record for every datapath that has ports
>>> referenced by the NB.Port_Group.ports field. In order to maintain the
>>> SB.Port_Group.name uniqueness constraint, ovn-northd populates the field
>>> with the value: <SB.Logical_Datapath.tunnel_key>_<NB.Port_Group.name>.
>>>
>>> In specific scenarios we see significant improvements in time to
>>> install/remove all logical flows to/from OVS. One such scenario, in the
>>> BZ referenced below has:
>>>
>>> $ ovn-nbctl acl-list pg
>>>    from-lport  1001 (inport == @pg && ip) drop
>>>      to-lport  1001 (outport == @pg && ip) drop
>>>
>>> Then, incrementally, creates new logical ports on different logical
>>> switches, binds them to OVS interfaces and adds them to the port_group.
>>>
>>> Measuring the total time to perform the above steps 500 times (for 500
>>> new ports attached to 100 switches, 5 per switch) on a test setup
>>> we observe an improvement of 50% in time it takes to install all
>>> openflow rules when port_groups are split in the SB database.
>>>
>>> Suggested-by: Numan Siddique <numans at ovn.org>
>>> Reported-by: Venkata Anil <anilvenkata at redhat.com>
>>> Reported-at: https://bugzilla.redhat.com/1818128
>>> Signed-off-by: Dumitru Ceara <dceara at redhat.com>
>>>
>>> ---
>>> v2:
>>> - add tests in ovn-northd.at as suggested by Numan.
>>>
>>
>> Thanks for v2 and adding tests.
>>
>> Acked-by: Numan Siddique <numans at ovn.org>
>>
>> Numan
> 
> I pushed this to master and branch-20.06
> 

Thanks, Numan and Mark, for the reviews.

Regards,
Dumitru