[ovs-dev] [PATCH] lib/tc: only update the stats for non-empty counter

Simon Horman simon.horman at netronome.com
Tue Jun 30 16:33:11 UTC 2020


On Mon, Jun 29, 2020 at 05:31:18PM +0800, wenxu at ucloud.cn wrote:
> From: wenxu <wenxu at ucloud.cn>
> 
> A packet with first frag and execute act_ct action.
> The packet will stole by defrag. So the stats counter
> for "gact action goto chain" will always 0. The openvswitch
> update each action in order. So the flower stats finally
> alway be zero. The rule will be delete adter max-idle time
> even there are packet executing the action.
> 
> ovs-appctl dpctl/dump-flows
> recirc_id(0),in_port(1),eth_type(0x0800),ipv4(dst=11.0.0.7,frag=first), packets:0, bytes:0, used:5.390s, actions:ct(zone=1,nat),recirc(0x4)
> 
> filter protocol ip pref 2 flower chain 0 handle 0x2
>   eth_type ipv4
>   dst_ip 1.1.1.1
>   ip_flags frag/firstfrag
>   skip_hw
>   not_in_hw
>  action order 1: ct zone 1 nat pipe
>   index 2 ref 1 bind 1 installed 11 sec used 1 sec
>  Action statistics:
>  Sent 15000 bytes 11 pkt (dropped 0, overlimits 0 requeues 0)
>  backlog 0b 0p requeues 0
>  cookie e04106c2ac41769b278edaa9b5309960
> 
>  action order 2: gact action goto chain 1
>   random type none pass val 0
>   index 2 ref 1 bind 1 installed 11 sec used 11 sec
>  Action statistics:
>  Sent 0 bytes 0 pkt (dropped 0, overlimits 0 requeues 0)
>  backlog 0b 0p requeues 0
>  cookie e04106c2ac41769b278edaa9b5309960
> 
> Signed-off-by: wenxu <wenxu at ucloud.cn>

Thanks,

this patch looks good to me.

I've added it to Travis CI for it to check with a view to pushing this
change.

https://travis-ci.org/github/horms2/ovs/builds/703600018


More information about the dev mailing list