[ovs-dev] [PATCH v4] db-ctl-base: add uuid specified method for create cmd

Ben Pfaff blp at ovn.org
Fri Mar 6 21:17:37 UTC 2020

On Mon, Mar 02, 2020 at 11:21:56AM +0800, Tao YunXiang wrote:
> Commit a529e3cd1f (ovsdb-server: Allow OVSDB clients to specify the
> UUID for inserted rows) solves ovsdb-client specifing the UUID for
> insert operation.  OVSDB now can support directly using uuid to identify
> a row. But for xxxctl tool,specifying uuid when creating a row is not
> yet supported . This patch tried to specify uuid when creating a row
> by the ctl tools. A new parameter --row_uuid is added to setup row's UUID.
> e.g. ovn-nbctl --row_uuid=3da0398b-a5a8-4bc9-808d-fa662865138f  create
> logical_switch name='abc'
> Co-authored-by: Liu Chang <liuchang at cmss.chinamobile.com>
> Co-authored-by: Rong Yin <rongyin at cmss.chinamobile.com>
> Signed-off-by: Tao YunXiang <taoyunxiang at cmss.chinamobile.com>
> Signed-off-by: Liu Chang <liuchang at cmss.chinamobile.com>
> Signed-off-by: Rong Yin <rongyin at cmss.chinamobile.com>
> CC: Han Zhou <hzhou at ovn.org>

Thanks for the patch.

"git am" complains about a corrupt patch and I have to agree with it.
For example, the following patch hunk claims to have 7 lines but only
has 6 lines (that don't change anything):

> diff --git a/lib/ovsdb-data.c b/lib/ovsdb-data.c
> index 4828624f6..0ea8d4494 100644
> --- a/lib/ovsdb-data.c
> +++ b/lib/ovsdb-data.c
> @@ -2223,7 +2223,7 @@ ovsdb_atom_range_check_size(int64_t range_start, int64_t range_end)
>      }
>      return NULL;
>  }
>  char *
>  ovsdb_data_row_name(const struct uuid *uuid)
>  {

More information about the dev mailing list