[ovs-dev] [PATCH v4 1/2] Add file descriptor persistence where possible

Ben Pfaff blp at ovn.org
Fri Mar 6 22:42:11 UTC 2020


Sounds good.

On Fri, Mar 06, 2020 at 10:36:28PM +0000, Anton Ivanov wrote:
> I have a cleaner version in the works which should be ready some times next
> week.
> 
> I will try to release the next version ~ Tue/Wed along with some level of
> async IO as well as reduction of copying in the json rpc TX path.
> 
> A.
> 
> On 06/03/2020 21:38, Ben Pfaff wrote:
> > On Wed, Feb 26, 2020 at 03:24:17PM +0000, anton.ivanov at cambridgegreys.com wrote:
> > > From: Anton Ivanov <anton.ivanov at cambridgegreys.com>
> > > 
> > > 1. Adds "persistent" behaviour where feasible streams.
> > > These are waited upon in the same thread where they are created. This
> > > allows them to be registered persistently with the OS (if possible)
> > > as well as the OS to provide hints - is the FD ready, is it closed,
> > > etc.
> > > 
> > > 2. Removes unnecessary attempts to perform a read vs EAGAIN on a fd
> > > which is not ready if the thread has a persistent poll loop.
> > > 
> > > 3. Enables fd persistence for ovsdb main server thread only
> > > 
> > > Signed-off-by: Anton Ivanov <anton.ivanov at cambridgegreys.com>
> > Thanks for the patches.
> > 
> > These have lots and lots of coding style violations, as reported by the
> > checkpatch robot.  Would you mind fixing those up and resubmitting a v5?
> > 
> > Thanks,
> > 
> > Ben.
> > 
> 
> -- 
> Anton R. Ivanov
> Cambridgegreys Limited. Registered in England. Company Number 10273661
> https://www.cambridgegreys.com/
> 


More information about the dev mailing list