[ovs-dev] [PATCH 7/7] raft: Fix next_index in install_snapshot reply handling.

Han Zhou hzhou at ovn.org
Fri Mar 6 22:47:50 UTC 2020


On Fri, Mar 6, 2020 at 2:32 PM Ben Pfaff <blp at ovn.org> wrote:
>
> On Fri, Feb 28, 2020 at 06:07:10PM -0800, Han Zhou wrote:
> > When a leader handles install_snapshot reply, the next_index for
> > the follower should be log_start instead of log_end, because there
> > can be new entries added in leader's log after initiating the
> > install_snapshot procedure.  Also, it should send all the accumulated
> > entries to follower in the following append-request message, instead
> > of sending 0 entries, to speed up the converge.
> >
> > Without this fix, there is no functional problem, but it takes
> > uncessary extra rounds of append-requests responsed with "inconsistency"
> > by follower, although finally will be converged.
> >
> > Signed-off-by: Han Zhou <hzhou at ovn.org>
>
> Thanks so much for all the fixes!  I applied these to master.  Let me
> know if you want me to backport any of them.

Thanks Ben! Could you help backport at least 1/7 - 4/7 to branch-2.12 and
2.13? 5/7 - 7/7 are not major problems, so I think it is ok not backporting
them.


More information about the dev mailing list