[ovs-dev] [PATCH v1 1/3] lib: implement scalable direct address table for fast lookup

0-day Robot robot at bytheb.org
Thu Mar 12 09:58:54 UTC 2020


Bleep bloop.  Greetings Yanqin Wei, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Improper whitespace around control block
#326 FILE: lib/sda-table.h:107:
#define SDA_TABLE_NODE_FOR_EACH(NODE, MEMBER, SDA_TABLE_NODE)             \

ERROR: Improper whitespace around control block
#331 FILE: lib/sda-table.h:112:
#define SDA_TABLE_FOR_EACH_WITH_ID(NODE, MEMBER, ID, SDA_TABLE)          \

ERROR: Improper whitespace around control block
#332 FILE: lib/sda-table.h:113:
    SDA_TABLE_NODE_FOR_EACH(NODE, MEMBER, sda_table_find_node(SDA_TABLE, ID))

ERROR: Improper whitespace around control block
#334 FILE: lib/sda-table.h:115:
#define SDA_TABLE_CURSOR_FOR_EACH__(NODE, CURSOR, MEMBER)   \

ERROR: Improper whitespace around control block
#340 FILE: lib/sda-table.h:121:
#define SDA_TABLE_FOR_EACH(NODE, MEMBER, SDA_TABLE) \

ERROR: Inappropriate bracing around statement
#343 FILE: lib/sda-table.h:124:
             SDA_TABLE_CURSOR_FOR_EACH__ (NODE, &cursor__, MEMBER);  \

Lines checked: 349, Warnings: 0, Errors: 6


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list