[ovs-dev] [PATCH v5] db-ctl-base: add uuid specified method for create cmd
blp at ovn.org
Fri Mar 13 18:30:02 UTC 2020
On Mon, Mar 09, 2020 at 05:20:18PM +0800, Tao YunXiang wrote:
> Commit a529e3cd1f (ovsdb-server: Allow OVSDB clients to specify the
> UUID for inserted rows) solves ovsdb-client specifing the UUID for
> insert operation. OVSDB now can support directly using uuid to identify
> a row. But for xxxctl tool,specifying uuid when creating a row is not
> yet supported . This patch tried to specify uuid when creating a row
> by the ctl tools. A new parameter --row_uuid is added to setup row's UUID.
> e.g. ovn-nbctl --row_uuid=3da0398b-a5a8-4bc9-808d-fa662865138f create
> logical_switch name='abc'
> Co-authored-by: Liu Chang <liuchang at cmss.chinamobile.com>
> Signed-off-by: Tao YunXiang <taoyunxiang at cmss.chinamobile.com>
> Signed-off-by: Liu Chang <liuchang at cmss.chinamobile.com>
> CC: Han Zhou <hzhou at ovn.org>
> CC: Ben Pfaff<blp at ovn.org>
Thanks for the patch.
I think that this feature interacts badly with the existing --id
option. If --id and --row-uuid are specified, then the UUID for the
symbol specified on --id should be taken from --row-uuid, but I do not
think that happens in this case.
Please add a test.
More information about the dev