[ovs-dev] [PATCH] tc: Fix nat port range when offloading ct action

Roi Dayan roid at mellanox.com
Tue Mar 17 14:14:44 UTC 2020



On 2020-03-17 4:10 PM, Roi Dayan wrote:
> 
> 
> On 2020-03-11 4:43 PM, Paul Blakey wrote:
>> Up
>>
>> On 3/8/2020 2:50 PM, Paul Blakey wrote:
>>> Port range struct is currently union so the last min/max port assignment
>>> wins, and kernel doesn't receive the range.
>>>
>>> Change it to struct type.
>>>
>>> Fixes: 2bf6ffb76ac6 ("netdev-offload-tc: Add conntrack nat support")
>>> Signed-off-by: Paul Blakey <paulb at mellanox.com>
>>> ---
>>>  lib/tc.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/tc.h b/lib/tc.h
>>> index d31c095..24a4994 100644
>>> --- a/lib/tc.h
>>> +++ b/lib/tc.h
>>> @@ -235,7 +235,7 @@ struct tc_action {
>>>                      } ipv6;
>>>                  };
>>>  
>>> -                union {
>>> +                struct {
>>>                      ovs_be16 min;
>>>                      ovs_be16 max;
>>>                  } port;
>>
> 
> Acked-by: Roi Dayan <roid at mellanox.com>
> 
> 
> Hi Simon, Ilya, can you help getting this merged? small fix.
> 
> thanks,
> Roi
> 

My mistake. I see Ben merged it already but didn't notice.


More information about the dev mailing list