[ovs-dev] 答复: 答复: 答复: [PATCH v6] Use TPACKET_V3 to accelerate veth for userspace datapath

Ben Pfaff blp at ovn.org
Tue Mar 17 16:37:13 UTC 2020


Great.  Then we do not need any special case for if_packet.h.

On Mon, Mar 16, 2020 at 12:48:20AM +0000, Yi Yang (杨燚)-云服务集团 wrote:
> All the definitions/macros have been in include/linux/if_packet.h since 3.10.0, so there will not be that case existing. 
> 
> -----邮件原件-----
> 发件人: Ben Pfaff [mailto:blp at ovn.org] 
> 发送时间: 2020年3月15日 4:04
> 收件人: Yi Yang (杨燚)-云服务集团 <yangyi01 at inspur.com>
> 抄送: u9012063 at gmail.com; yang_y_yi at 163.com; ovs-dev at openvswitch.org
> 主题: Re: 答复: 答复: [ovs-dev] [PATCH v6] Use TPACKET_V3 to accelerate veth for userspace datapath
> 
> There might still be a misunderstanding.
> 
> There can be a difference between the kernel that OVS runs on (version
> A) and the kernel headers against which it is built (version B).  Often, the latter are supplied by the distribution and they are not usually kept as up to date, so B < A is common.
> 
> I don't know whether this is likely to be a problem in this particular case.
> 
> On Sat, Mar 14, 2020 at 03:35:46AM +0000, Yi Yang (杨燚)-云服务集团 wrote:
> > Got it, then we can safely remove inclue/linux/if_packet.h in ovs 
> > because the minimal Linux version OVS supports has supported 
> > tpacket_v3. Thanks Ben for clarification.
> > 
> > -----邮件原件-----
> > 发件人: Ben Pfaff [mailto:blp at ovn.org]
> > 发送时间: 2020年3月13日 23:57
> > 收件人: Yi Yang (杨燚)-云服务集团 <yangyi01 at inspur.com>
> > 抄送: u9012063 at gmail.com; yang_y_yi at 163.com; ovs-dev at openvswitch.org
> > 主题: Re: 答复: [ovs-dev] [PATCH v6] Use TPACKET_V3 to accelerate veth for 
> > userspace datapath
> > 
> > On Fri, Mar 13, 2020 at 01:04:07AM +0000, Yi Yang (杨燚)-云服务集团 wrote:
> > > Per my understanding, Ben meant a build system (which isn't Linux 
> > > probably, it doesn't have include/linux/if_packet.h) should be able 
> > > to build tpacket_v3 code in order that built-out binary can work on 
> > > Linux system with tpacket_v3 feature, this is Ben's point, that is 
> > > why he wanted me to add include/linux/if_packet.h in ovs repo.
> > > 
> > > Ben, can you help double confirm if include/linux/if_packet.h in ovs 
> > > is necessary?
> > 
> > I think my meaning was misunderstood.  Linux always has if_packet.h.
> > Only recent enough Linux has TPACKET_V3 in if_packet.h.  If the system is Linux but the TPACKET_V3 types and constants are not defined in if_packet.h, then the build system should define them.
> 
> 




More information about the dev mailing list