[ovs-dev] [PATCH] hmap.h: Fix Coverity false positive

Ben Pfaff blp at ovn.org
Thu Mar 19 00:36:44 UTC 2020

On Wed, Mar 18, 2020 at 05:32:03PM -0700, Usman Ansari wrote:
> Suggested-by: Ben Pfaff <blp at ovn.org>
> Coverity reports a false positive below:
> Incorrect expression, Assign_where_compare_meant: use of "="
> where "==" may have been intended.
> Fixed it by rewriting '(NODE = NULL)' as '((NODE = NULL), false)'.
> "make check" passes for this change
> Coverity reports 80 errors resolved
> Signed-off-by: Usman Ansari <u1422 at gmail.com>


This doesn't apply.  "git am" says:

    Applying: hmap.h: Fix Coverity false positive
    error: corrupt patch at line 14
    Patch failed at 0001 hmap.h: Fix Coverity false positive
    hint: Use 'git am --show-current-patch' to see the failed patch
    When you have resolved this problem, run "git am --continue".
    If you prefer to skip this patch, run "git am --skip" instead.
    To restore the original branch and stop patching, run "git am --abort".

Also, all tags go at the bottom of the commit message, that is,
Suggested-by is in the wrong place.  The committer documentation has
some more rules for tags.

More information about the dev mailing list