[ovs-dev] [PATCH] dpif-netlink: avoid netlink modify flow put op failed after tc modify flow put op failed.

Simon Horman simon.horman at netronome.com
Thu Mar 19 11:04:40 UTC 2020


On Thu, Mar 19, 2020 at 11:28:00AM +0200, Roi Dayan wrote:
> 
> 
> On 2020-03-11 7:39 AM, wenxu at ucloud.cn wrote:
> > From: wenxu <wenxu at ucloud.cn>
> > 
> > The tc modify flow put always delete the original flow first and
> > then add the new flow. If the modfiy flow put operation failed,
> > the flow put operation will change from modify to create if success
> > to delete the original flow in tc (which will be always failed with
> > ENOENT, the flow is already be deleted before add the new flow in tc).
> > Finally, the modify flow put will failed to add in kernel datapath.
> > 
> > Signed-off-by: wenxu <wenxu at ucloud.cn>

...

> Acked-by: Roi Dayan <roid at mellanox.com>

Thanks,

this looks good to me.

I am exercising the patch applied on top of master and branch-2.13
using Travis CI. And I plan to push the patch to those branches if
that succeeds.

The patch does not apply cleanly on branch-2.12. Please consider
posting a backport to that and earlier branches if the change
is appropriate there.


More information about the dev mailing list