[ovs-dev] [PATCH] hmap.h: Fix Coverity false positive

Ben Pfaff blp at ovn.org
Thu Mar 19 22:09:18 UTC 2020


On Thu, Mar 19, 2020 at 02:47:17PM -0700, ua1422 at gmail.com wrote:
> From: Usman Ansari <ua1422 at gmail.com>
> 
> Coverity reports a false positive below:
> Incorrect expression, Assign_where_compare_meant: use of "="
> where "==" may have been intended.
> Fixed it by rewriting '(NODE = NULL)' as '((NODE = NULL), false)'.
> "make check" passes for this change
> Coverity reports over 500 errors resolved
> 
> Suggested-by: Ben Pfaff <blp at ovn.org>
> Signed-off-by: Usman Ansari <u1422 at gmail.com>

Thanks.  I folded the too-long lines, fixed the typo in your
Signed-off-by line, and applied this to master.


More information about the dev mailing list