[ovs-dev] [PATCH] ofproto-dpif-xlate: Fix recirculation when in_port is OFPP_CONTROLLER.

Ben Pfaff blp at ovn.org
Fri Mar 20 15:28:15 UTC 2020


On Fri, Mar 20, 2020 at 02:12:55PM +0530, Numan Siddique wrote:
> On Fri, Mar 20, 2020 at 6:26 AM Ben Pfaff <blp at ovn.org> wrote:
> >
> > Recirculation usually requires finding the pre-recirculation input port.
> > Packets sent by the controller, with in_port of OFPP_CONTROLLER or
> > OFPP_NONE, do not have a real input port data structure, only a port
> > number.  The code in xlate_lookup_ofproto_() mishandled this case,
> > failing to return the ofproto data structure.  This commit fixes the
> > problem and adds a test to guard against regression.
> >
> > Reported-by: Numan Siddique <numans at ovn.org>
> > Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2020-March/368642.html
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> 
> Thanks for fixing this issue.
> 
> Tested-by: Numan Siddique <numans at ovn.org>
> Acked-by: Numan Siddique <numans at ovn.org>
> 
> Can you please also backport this patch to branch-2.13 ?

Thanks for testing and for the high quality bug report.

I applied this to master and branch-2.13.


More information about the dev mailing list