[ovs-dev] [PATCH v7 ovn 0/2] Add IPv6 Prefix delegation (RFC3633)

Numan Siddique numans at ovn.org
Sat Mar 21 15:28:37 UTC 2020


On Wed, Mar 18, 2020 at 7:49 PM Lorenzo Bianconi
<lorenzo.bianconi at redhat.com> wrote:
>
> Introduce IPv6 Prefix delegation state machine according to RFC 3633
> https://tools.ietf.org/html/rfc3633.
> Add handle_dhcpv6_reply controller action to parse advertise/reply from
> IPv6 delegation server.
> Introduce logical flows in ovn router pipeline in order to parse dhcpv6
> advertise/reply from IPv6 prefix delegation router.
> This series relies on the following OVS commit:
> https://github.com/openvswitch/ovs/commit/cec89046f72cb044b068ba6a4e30dbcc4292c4c1
>


Hi Lorenzo,

Thank for v7.

I didn't give a thorough code review. But I tested the patches out. I
found a couple of issues

1. After the prefix delegation is enabled on all the logical router
ports and ovn-controller receiving
the PD from the delegating server, If I run the below command
****
ovn-nbctl set logical_router_port rp-sw0 options:prefix=false
****
ovn-controller doesn't remove this lport from the 'ipv6_prefixd'
shash. And I noticed that
ovn-controller keeps sending the solicit messages when the time for
the renewal comes.

2. When I restart ovn-controller, it does send the solicit messages
for all the router ports
configured with PD, but it doesn't include the "IA Prefix" in the
Solicit message as a hint.


I have a few suggestions for the system test
  - Please test out the scenario of disabling prefix=false and then
reenabling it and make
    sure that ovn-controller sends the solicit when prefix=true is set again

  - Please modify the dibble.conf file  and set t1 and t2 to very
short values like 10 seconds
    and make sure that ovn-controller sends the solicit messages when
the time for renewal
    comes.


Thanks
Numan







> Changes since v6:
> - fix documentation
> - convert handle_dhcpv6_reply from netsted to plain action
> - code reworking to reduce cpu utilization
> - insert configured prefix as hint in dhcp pd messages
>
> Changes since v5:
> - introduce ipv6_prefix column in logical_router_port table to save ipv6 prefix
>   received from delegation router
>
> Changes since v4:
> - improve unit test support
> - fix ovn-controller crash
> - confifure prefixes received from delegation router in RA
> - allow the requesting router to rely on lla address for PD protocol
>
> Changes since v3:
> - cosmetics
> - add a provider bridge in the unit-test deployment and add a localnet
>   port to the deployment to access the underlay network
> - request IPv6 prefix even for bar router logical port in the unit-test
>   deployment
>
> Changes since v2:
> - add unitest support in system-ovn.at
>
> Changes since v1:
> - rebase on top of ovn master branch
> - request an IPv6 prefix for each 'downstream' logical router port marked with
>   prefix set to true
> - add missing documentation
> - rename dhcp6_server_pkt in handle_dhcpv6_reply
>
> Lorenzo Bianconi (2):
>   controller: add ipv6 prefix delegation state machine
>   northd: add logical flows for dhcpv6 pfd parsing
>
>  controller/pinctrl.c    | 659 +++++++++++++++++++++++++++++++++++++++-
>  controller/pinctrl.h    |   1 +
>  include/ovn/actions.h   |   8 +-
>  lib/actions.c           |  16 +
>  lib/ovn-l7.h            |  19 ++
>  northd/ovn-northd.8.xml |   8 +
>  northd/ovn-northd.c     |  95 +++++-
>  ovn-nb.ovsschema        |   7 +-
>  ovn-nb.xml              |  21 ++
>  ovn-sb.xml              |  18 ++
>  tests/atlocal.in        |   5 +-
>  tests/ovn.at            |   4 +
>  tests/system-ovn.at     | 127 ++++++++
>  utilities/ovn-trace.c   |   2 +
>  14 files changed, 974 insertions(+), 16 deletions(-)
>
> --
> 2.25.1
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list