[ovs-dev] [PATCH v6] db-ctl-base: add uuid specified method for create cmd

Ben Pfaff blp at ovn.org
Mon Mar 23 15:22:52 UTC 2020

> >This introduces duplicate code blocks into cmd_create(). Don't do that.
> We can't understand: do you mean that the row-uuid code block under if(id) is redundant ? Or we should add some additional code block ?

You added two copies of the following.

+            if (!uuid_from_string(&uuid_from_cmd, row_uuid)) {
+                ctl_error(ctx, "row-uuid '%s' is not a valid UUID", row_uuid);
+                return;
+            }

> >Please add a test that using an id before creating the record works with
> >--row-uuid. I do not think that it currently works.
> In patch v6 
> We have added a test in ovs-vsctl.at which is about --row-uuid after --id for 
> create cmd.

There is no test that uses an ID on a command *before* the "create"
command.  The documentation says this works.  Please test it.

More information about the dev mailing list