[ovs-dev] Clang compilation broken on master (ecd4a8f)

Dave Tucker datucker at redhat.com
Mon Mar 23 18:32:53 UTC 2020


Hi all!

Current master branch is failing to compile under clang.
The problem was introduced in this commit (applied 4 hours ago).
https://github.com/openvswitch/ovs/commit/ecd4a8fcdff2ebf35cdb36355167d34e99df6dd5

lib/vlog.c:618:12: error: reading variable 'log_fd' requires holding mutex
'log_file_mutex' [-Werror,-Wthread-safety-analysis]
return log_fd;
^

Based on the error I'd suggest reverting the patch and reworking it to 
safely acquire/release log_file_mutex.

All the best,

- Dave


More information about the dev mailing list