[ovs-dev] [PATCH v8] db-ctl-base: add uuid specified method for create cmd

0-day Robot robot at bytheb.org
Wed Mar 25 05:59:53 UTC 2020


Bleep bloop.  Greetings Tao YunXiang, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 198 characters long (recommended limit is 79)
#105 FILE: lib/db-ctl-base.xml:293:
    <dt>[<code>--id=@</code><var>name</var>] [<code>--row-uuid=</code><var>uuid</var>] <code>create</code> <var>table column</var>[<code>:</code><var>key</var>]<code>=</code><var>value</var>...</dt>

WARNING: Line is 93 characters long (recommended limit is 79)
WARNING: Line has trailing whitespace
#114 FILE: lib/db-ctl-base.xml:307:
        If <code></code><var>uuid</var> is supplied and is reasonable, then the UUID for the 

WARNING: Line has trailing whitespace
#115 FILE: lib/db-ctl-base.xml:308:
        new row may be specified as expected. 

WARNING: Line is 94 characters long (recommended limit is 79)
WARNING: Line has trailing whitespace
#118 FILE: lib/db-ctl-base.xml:311:
        If both <code>@</code><var>name</var> and <code></code><var>uuid</var> are specified, 

WARNING: Line is 92 characters long (recommended limit is 79)
WARNING: Line has trailing whitespace
#119 FILE: lib/db-ctl-base.xml:312:
        the new row with corresponding uuid may still be referred to by that name, but this 

WARNING: Line has trailing whitespace
#120 FILE: lib/db-ctl-base.xml:313:
        references can only follow the <code>create</code> command.   

WARNING: Line is 85 characters long (recommended limit is 79)
#179 FILE: lib/ovsdb-idl.c:4169:
                                        xasprintf(UUID_FMT, UUID_ARGS(&row->uuid))));

Lines checked: 277, Warnings: 10, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list