[ovs-dev] [PATCH] netdev-offload-tc: Flush rules on ingress block when init tc flow api

Simon Horman simon.horman at netronome.com
Wed Mar 25 17:48:31 UTC 2020


On Tue, Mar 24, 2020 at 01:49:37PM +0100, Simon Horman wrote:
> On Tue, Mar 24, 2020 at 11:42:13AM +0200, Dmytro Linkin wrote:
> > On Tue, Mar 03, 2020 at 07:37:45PM +0200, Dmytro Linkin wrote:
> > > On Tue, Mar 03, 2020 at 04:42:12PM +0100, Ilya Maximets wrote:
> > > > On 3/3/20 4:29 PM, Dmytro Linkin wrote:
> > > > > On Tue, Mar 03, 2020 at 02:15:21PM +0100, Ilya Maximets wrote:
> > > > >> On 3/3/20 8:58 AM, Roi Dayan wrote:
> > > > >>>
> > > > >>>
> > > > >>> On 2020-02-27 5:22 PM, Roi Dayan wrote:
> > > > >>>> From: Dmytro Linkin <dmitrolin at mellanox.com>
> > > > >>>>
> > > > >>>> OVS can fail to attach ingress block on iface when init tc flow api,
> > > > >>>> if block already exist with rules on it and is shared with other iface.
> > > > >>>> Fix by flush all existing rules on the ingress block prior to deleting
> > > > >>>> it.
> > > > >>>>
> > > > >>>> Fixes: 093c9458fb02 ("tc: allow offloading of block ids")
> > > > >>>> Signed-off-by: Dmytro Linkin <dmitrolin at mellanox.com>
> > > > >>>> Acked-by: Raed Salem <raeds at mellanox.com>
> > > > >>>> Acked-by: Roi Dayan <roid at mellanox.com>
> 
> ...
> 
> > Ping
> 
> Sorry for the delay.
> 
> This seems reasonable. I am running it through Travis CI and if
> that succeeds I plan to push it to master, branch-2.13 and branch-2.12.
> 
> It did not seem to apply cleanly to branches for older releases
> so please consider submitting backports if appropriate.
> 
> https://travis-ci.org/github/horms2/ovs/builds/666306585
> https://travis-ci.org/github/horms2/ovs/builds/666306504
> https://travis-ci.org/github/horms2/ovs/builds/666305789

Thanks again,

I have pushed this patch to master and branch-2.13.

Travis tells me that the patch does not compile cleanly when
applied to branch-2.12. Please consider supplying a backport if
appropriate.


More information about the dev mailing list