[ovs-dev] [PATCHv5] userspace: Add conntrack timeout policy support.

William Tu u9012063 at gmail.com
Fri May 1 15:26:27 UTC 2020


On Thu, Apr 30, 2020 at 03:29:45PM -0700, Yi-Hung Wei wrote:
> On Wed, Apr 29, 2020 at 12:25 PM William Tu <u9012063 at gmail.com> wrote:
> >
> > Commit 1f1613183733 ("ct-dpif, dpif-netlink: Add conntrack timeout
> > policy support") adds conntrack timeout policy for kernel datapath.
> > This patch enables support for the userspace datapath.  I tested
> > using the 'make check-system-userspace' which checks the timeout
> > policies for ICMP and UDP cases.
> >
> > Signed-off-by: William Tu <u9012063 at gmail.com>
> > ---
> > v5: address feedback from Yi-Hung
> >   - couple improvement for error handling
> >   - travis: https://travis-ci.org/github/williamtu/ovs-travis/builds/681160951
> >   - currently failed due to kernel issue
> >
> > v4: address feedback from Yi-Hung
> >   - move default policy value to lib/conntrack-tp.c
> >   - separate icmp bug patch
> >   - refactor and fix include issues
> >   - fix the clang lock analysis annotation
> >   - keep clean interval to 5 seconds
> >   - improve tests in system-traffic.at
> >   - travis: https://travis-ci.org/github/williamtu/ovs-travis/builds/680158645
> >
> > v3:
> >   - address feedback from Yi-Hung
> >   - use ID 0 as default policy
> >   - move conn_{init,update}_expiration to lib/conntrack-tp.c
> >   - s/tpid/tp_id/
> >   - add default timeout value to CT_DPIF_TP_*_ATTRs
> >   - reduce the CT_CLEAN_INTERVAL from 5 to 3s, to make the tests
> >     run faster.
> >   - add more tests to system-traffic.at
> >   - code refactoring and renaming
> > ---
> 
> Thanks for this new version. It looks good to me.
> 
> Acked-by: Yi-Hung Wei <yihung.wei at gmail.com>

Applied to master, thanks.



More information about the dev mailing list