[ovs-dev] [PATCH v4] AB bonding: Add "primary" interface concept

Aaron Conole aconole at redhat.com
Tue May 12 17:37:02 UTC 2020


"Jeff Squyres (jsquyres)" <jsquyres at cisco.com> writes:

> On May 6, 2020, at 11:08 AM, Aaron Conole <aconole at redhat.com> wrote:
>
>  Jeff Squyres via dev <ovs-dev at openvswitch.org> writes:
>
>  In AB bonding, if the current active slave becomes disabled, a
>  replacement slave is arbitrarily picked from the remaining set of
>  enabled slaves.  This commit adds the concept of a "primary" slave: an
>  interface that will always be (or become) the current active slave if
>  it is enabled.
>
>  The rationale for this functionality is to allow the designation of a
>  preferred interface for a given bond.  For example:
>
>  1. Bond is created with interfaces p1 (primary) and p2, both enabled.
>  2. p1 becomes the current active slave (because it was designated as
>    the primary).
>  3. Later, p1 fails/becomes disabled.
>  4. p2 is chosen to become the current active slave.
>  5. Later, p1 becomes re-enabled.
>  6. p1 is chosen to become the current active slave (because it was
>    designated as the primary)
>
>  Note that p1 becomes the active slave once it becomes re-enabled, even
>  if nothing has happened to p2.
>
>  This "primary" concept exists in Linux kernel network interface
>  bonding, but did not previously exist in OVS bonding.
>
>  Only one primary slave inteface is supported per bond, and is only
>  supported for active/backup bonding.
>
>  The primary slave interface is designated via
>  "other_config:bond-primary" when creating a bond.
>
>  Signed-off-by: Jeff Squyres \(jsquyres\) <jsquyres at cisco.com>
>  ---
>
>  LGTM
>
>  Acked-by: Aaron Conole <aconole at redhat.com>
>
> Thanks! 
>
> I'm somewhat new to this community / this process.  With the positive reviews, is there anything else that needs to be
> done?  Or will this patch just show up at some point in the git logs of https://github.com/openvswitch/ovs/?

Ilya will hopefully merge it at some point.  I'll ping him on IRC
tomorrow (it's evening time for him).  It can sometimes take a week or
so before someone gets to merge it.  OVS can sometimes be slow to merge
patches.



More information about the dev mailing list