[ovs-dev] [PATCH v2] Encap & Decap actions for MPLS Packet Type

[Martin Varghese]

On Sun, Apr 19, 2020 at 02:33:45PM +0200, Ilya Maximets wrote:
> On 4/18/20 7:24 AM, Varghese, Martin (Nokia - IN/Bangalore) wrote:
> > Hi Ilya
> > 
> > I have the patches updated but it is in a crude form. I had to defer the work as I got busy with other commitments 
> > I am targeting to send updated patch with in couple of weeks.
> 
> Cool.  Thanks!
>
The updated patch series is sent to dev at openvswitch.org.
Please let me know the feedback. 
> > 
> > Regards,
> > Martin
> > 
> > 
> > -----Original Message-----
> > From: Ilya Maximets <i.maximets at ovn.org> 
> > Sent: Saturday, April 18, 2020 1:54 AM
> > To: Martin Varghese <martinvarghesenokia at gmail.com>; dev at openvswitch.org; pshelar at ovn.org; Drennan, Scott (Nokia - US/Mountain View) <scott.drennan at nokia.com>
> > Cc: Varghese, Martin (Nokia - IN/Bangalore) <martin.varghese at nokia.com>; i.maximets at ovn.org; Greg Rose <gvrose8192 at gmail.com>
> > Subject: Re: [ovs-dev] [PATCH v2] Encap & Decap actions for MPLS Packet Type
> > 
> > On 12/10/19 9:17 AM, Martin Varghese wrote:
> >> From: Martin Varghese <martin.varghese at nokia.com>
> >>
> >> The existing PUSH MPLS & POP MPLS actions inserts & removes MPLS 
> >> header between ethernet header and the IP header. Though this 
> >> behaviour is fine for L3 VPN where an IP packet is encapsulated inside 
> >> a MPLS tunnel, it does not suffice the L2 VPN requirements. In L2 VPN 
> >> the ethernet packets must be encapsulated inside MPLS tunnel
> >>
> >> In this change the encap & decap actions are extended to support MPLS 
> >> packet type. The encap & decap adds and removes MPLS header at the 
> >> start of packet as depicted below.
> >>
> >> Encapsulation:
> >>
> >> Actions - encap(mpls(ether_type=0x8847)),encap(ethernet)
> >>
> >> Incoming packet -> | ETH | IP | Payload |
> >>
> >> 1 Actions -  encap(mpls(ether_type=0x8847)) [Kernel action - 
> >> ptap_push_mpls:0x8847]
> >>
> >>         Outgoing packet -> | MPLS | ETH | Payload|
> >>
> >> 2 Actions - encap(ethernet) [ Kernel action - push_eth ]
> >>
> >>         Outgoing packet -> | ETH | MPLS | ETH | Payload|
> >>
> >> Decapsulation:
> >>
> >> Incoming packet -> | ETH | MPLS | ETH | IP | Payload |
> >>
> >> Actions - decap(),decap(packet_type(ns=0,type=0)
> >>
> >> 1 Actions -  decap() [Kernel action - pop_eth)
> >>
> >>         Outgoing packet -> | MPLS | ETH | IP | Payload|
> >>
> >> 2 Actions - decap(packet_type(ns=0,type=0) [Kernel action - 
> >> ptap_pop_mpls:0]
> >>
> >>         Outgoing packet -> | ETH  | IP | Payload
> >>
> >> Signed-off-by: Martin Varghese <martin.varghese at nokia.com>
> >> ---
> > 
> > Hi, Martin.
> > 
> > This change is in kernel already for some time, I'm wondering if you are going to update this patch according to changes made while pushing this feature to kernel and re-send new version so we could actually use this action in OVS?
> > 
> > Best regards, Ilya Maximets.
> > 
>