[ovs-dev] [PATCH 5/5] raft: Avoid having more than one snapshot in-flight.

Ilya Maximets i.maximets at ovn.org
Tue Nov 3 15:47:15 UTC 2020


On 10/28/20 11:58 AM, Dumitru Ceara wrote:
> On 10/26/20 2:42 AM, Ilya Maximets wrote:
>> Previous commit 8c2c503bdb0d ("raft: Avoid sending equal snapshots.")
>> took a "safe" approach to not send only exactly same snapshot
>> installation requests.  However, it doesn't make much sense to send
>> more than one snapshot at a time.  If obsolete snapshot installed,
>> leader will re-send the most recent one.
>>
>> With this change leader will have only 1 snapshot in-flight per
>> connection.  This will reduce backlogs on raft connections in case
>> new snapshot created while 'install_snapshot_request' is in progress
>> or if election timer changed in that period.
>>
>> Also, not tracking the exact 'install_snapshot_request' we've sent
>> allows to simplify the code.
>>
>> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1888829
>> Fixes: 8c2c503bdb0d ("raft: Avoid sending equal snapshots.")
>> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
>> ---
> 
> Looks good to me, thanks!
> 
> Acked-by: Dumitru Ceara <dceara at redhat.com>
> 


Thanks!  Applied to master.
Will backport down to 2.13 as soon as TravisCI finishes the check.

Best regards, Ilya Maximets.


More information about the dev mailing list