[ovs-dev] [PATCH ovn] actions: Fix issues with fwd_group action.

[Ben Pfaff]

On Wed, Nov 11, 2020 at 01:03:56PM +0530, Numan Siddique wrote:
> On Wed, Nov 11, 2020 at 6:49 AM Ben Pfaff <blp at ovn.org> wrote:
> >
> > The example for the fwd_group action was obviously wrong (it needed a
> > closing parenthesis and semicolon) and then when I looked closer I saw
> > other issues:
> >
> >   - It's weird to insist on "true" or "false" in quotation marks (why?)
> >     and the example didn't show that.
> >
> >   - The example didn't show that port names need to be quoted.
> >
> >   - The implementation didn't allow specifying liveness=false (why?)
> >     or liveness="false" and the test even checked for that.
> >
> > This fixes all that stuff.  For backward compatibility, it still accepts
> > "true" (and "false") in quotation marks, but now accepts without as well
> > for future use.
> >
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> 
> Oops. Thanks for fixing this.
> 
> Acked-by: Numan Siddique <numans at ovn.org>

Thanks.  I applied this to OVN master.