[ovs-dev] [PATCH v4 2/2] python: set ovs.dirs variables with build system values

[Ilya Maximets]

On 11/16/20 5:28 PM, Stokes, Ian wrote:
>> On Wed, 11 Nov 2020 04:25:30 -0500
>> Mark Gray <mark.d.gray at redhat.com> wrote:
>>
>>> ovs/dirs.py should be auto-generated using the template
>>> ovs/dirs.py.template at build time. This will set the
>>> ovs.dirs python variables with a value specified by the
>>> environment or, if the environment variable is not set, from
>>> the build system.
>>>
>>> Signed-off-by: Mark Gray <mark.d.gray at redhat.com>
>>
>> Acked-By: Timothy Redaelli <tredaelli at redhat.com>
>>
> 
> Thanks Timothy, I've pushed this series to master now.

Thanks, Ian.  But we might need a follow up on this change.
I think, the main reason why dirs.py existed is that we need
it while doing setup of python package, i.e. we should have
it during execution of python/ovs/setup.py.  Setup script
already checks if version.py exists, and we might want check
for dirs.py too, otherwise python package will be non-functional.

Also, gitignore file seems to have dir.py and not dirs.py.

Best regards, Ilya Maximets.