[ovs-dev] [PATCH V2 3/3] compat: Fix compile warning
Gregory Rose
gvrose8192 at gmail.com
Tue Nov 17 01:14:40 UTC 2020
On 11/16/2020 11:30 AM, Ilya Maximets wrote:
> On 11/13/20 8:24 PM, Yi-Hung Wei wrote:
>> On Thu, Nov 12, 2020 at 3:10 PM Greg Rose <gvrose8192 at gmail.com> wrote:
>>>
>>> In ../compat/nf_conntrack_reasm.c nf_frags_cache_name is declared
>>> if OVS_NF_DEFRAG6_BACKPORT is defined. However, later in the patch
>>> it is only used if HAVE_INET_FRAGS_WITH_FRAGS_WORK is defined and
>>> HAVE_INET_FRAGS_RND is not defined. This will cause a compile warning
>>> about unused variables.
>>>
>>> Fix it up by using the same defines that enable its use to decide
>>> if it should be declared and avoid the compiler warning.
>>>
>>> Fixes: 4a90b277baca ("compat: Fixup ipv6 fragmentation on 4.9.135+ kernels")
>>> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
>>>
>>> ---
>>> V2 No change
>>> ---
>> LGTM.
>>
>> Acked-by: Yi-Hung Wei <yihung.wei at gmail.com>
>
> Thanks!
>
> Applied to master and backported down to 2.6.
Thank you Ilya for this and the other two commits from this series.
- Greg
>
>
>
> Best regards, Ilya Maximets.
>
More information about the dev
mailing list