[ovs-dev] [PATCH] ovsdb-idl: Return correct seqno from ovsdb_idl_db_set_condition().

[Dumitru Ceara]

On 11/16/20 8:37 PM, Ilya Maximets wrote:
> On 11/10/20 3:34 PM, Dumitru Ceara wrote:
>> If an IDL client sets the same monitor condition twice, the expected
>> seqno when the IDL contents are updated should be the same for both
>> calls.
>>
>> In the following scenario:
>> 1. Client calls ovsdb_idl_db_set_condition(db, table, cond1)
>> 2. ovsdb_idl sends monitor_cond_change(cond1) but the server doesn't yet
>>    reply.
>> 3. Client calls ovsdb_idl_db_set_condition(db, table, cond1)
>>
>> At step 3 the returned expected seqno should be the same as at step 1.
>> Similarly, if step 2 is skipped, i.e., the client calls sets
>> the condition twice in the same iteration, then both
>> ovsdb_idl_db_set_condition() calls should return the same value.
>>
>> Fixes: 46437c5232bd ("ovsdb-idl: Enhance conditional monitoring API")
>> Signed-off-by: Dumitru Ceara <dceara at redhat.com>
>> ---
> 
> Thanks!
> 
> Applied to master and backported down to 2.12.

Thanks!

> 
> 
> It's hard to backport further since we have no fix for in-flight conditions
> below 2.12, but we likely do not need it there.
> 

I think it's fine (for OVN at least).

Thanks,
Dumitru