[ovs-dev] [PATCH ovn v5 5/8] tests: Eliminate most "sleep" calls.

Ben Pfaff blp at ovn.org
Thu Nov 19 05:11:05 UTC 2020


On Thu, Nov 12, 2020 at 12:25:24PM +0100, Dumitru Ceara wrote:
> On 11/12/20 2:45 AM, Ben Pfaff wrote:
> > Many of these could be replaced by "ovn-nbctl sync".  Some weren't
> > really needed at all because they were adjacent to something that itself
> > called sync or otherwise used --wait.  Some were more appropriately
> > done with explicit waits for what was really needed.
> > 
> > I left some "sleep"s.  Some were because they were "negative" sleeps:
> > they were giving time for something to happen that should *not* happen
> > (in other words, if you wait for it to happen, you'll wait forever,
> > unless there's a bug).  Some were because I didn't know how to properly
> > wait for what they were waiting for, or because I didn't understand
> > the circumstances deeply enough.
> > 
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > ---
> 
> There are still tests that occasionally fail when I run the suite with
> "-j20".
> 
> I'm pretty sure they're all related to the "--wait=hv sync" bug [0].
> 
> If I patch OVS to include the following IDL changes:
> -
> https://patchwork.ozlabs.org/project/openvswitch/patch/20201110121811.2205350-1-i.maximets@ovn.org/
> -
> https://patchwork.ozlabs.org/project/openvswitch/patch/1605018868-30691-1-git-send-email-dceara@redhat.com/
> 
> And if I patch OVN with the following commit which depends on the OVS
> patches:
> https://github.com/dceara/ovn/commit/c4926fbb386a3fa83c99618b6b12bcb4466fd1d6
> 
> Then the tests pass (or at least I'm not hitting this specific race
> condition anymore).
> 
> Would it be possible to have a look at the OVS IDL patches above?  Once
> those are merged I can cleanup and post the OVN patch.

I see that the first two above were applied.  I sent a question about
the third one (the OVN patch).

Thanks so much for helping me out with this!


More information about the dev mailing list