[ovs-dev] [PATCH ovn v7 5/5] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

Dumitru Ceara dceara at redhat.com
Thu Nov 19 08:11:38 UTC 2020


On 11/19/20 6:13 AM, Ben Pfaff wrote:
> From: Leonid Ryzhyk <lryzhyk at vmware.com>
> 
> This implementation is incremental, meaning that it only recalculates
> what is needed for the southbound database when northbound changes
> occur.  It is expected to scale better than the C implementation,
> for large deployments.  (This may take testing and tuning to be
> effective.)
> 
> There are three tests that I'm having mysterious trouble getting
> to work with DDlog.  For now, I've marked the testsuite to skip
> them unless RUN_ANYWAY=yes is set in the environment.
> 
> Signed-off-by: Leonid Ryzhyk <lryzhyk at vmware.com>
> Co-authored-by: Justin Pettit <jpettit at ovn.org>
> Signed-off-by: Justin Pettit <jpettit at ovn.org>
> Co-authored-by: Ben Pfaff <blp at ovn.org>
> Signed-off-by: Ben Pfaff <blp at ovn.org>
> Acked-by: Dumitru Ceara <dceara at redhat.com>

Hi Ben,

This is not a review, just a note that my "Acked-by" should probably go
to patch 2/5 "tests: Prepare for multiple northd types.".  Unless I'm
mistaken, I didn't review the last patch of the series yet, except the
fact that I tried running the OVN tests.

I'm not saying patch 5/5 "ovn-northd-ddlog: New implementation of
ovn-northd based on ddlog." is not good, just that I didn't review it yet :)

Thanks,
Dumitru



More information about the dev mailing list