[ovs-dev] [PATCH ovn] northd: Fix leaks of strings while formatting ecmp flows.

Ilya Maximets i.maximets at ovn.org
Fri Nov 20 00:22:18 UTC 2020


On 11/19/20 8:40 PM, Ilya Maximets wrote:
> Result of 'normalize_v46_prefix()' should be freed and all dynamic
> strings should be destroyed.
> 
>   Direct leak of 156 byte(s) in 13 object(s) allocated from:
>     #0 0x53700f in malloc (northd/ovn-northd+0x53700f)
>     #1 0x71b146 in xmalloc ovs/lib/util.c:138:15
>     #2 0x71b39a in xvasprintf ovs/lib/util.c:202:9
>     #3 0x71b753 in xasprintf ovs/lib/util.c:343:9
>     #4 0x59bddc in add_ecmp_symmetric_reply_flows northd/ovn-northd.c:7985:18
>     #5 0x59aab5 in build_ecmp_route_flow northd/ovn-northd.c:8102:13
>     #6 0x592260 in build_static_route_flows_for_lrouter ovn-northd.c:10243:13
>     #7 0x589267 in build_lswitch_and_lrouter_iterate_by_od ovn-northd.c:11241:5
>     #8 0x5888ca in build_lswitch_and_lrouter_flows northd/ovn-northd.c:11313:9
>     #9 0x5730a0 in build_lflows northd/ovn-northd.c:11401:5
>     #10 0x56f992 in ovnnb_db_run northd/ovn-northd.c:12339:5
>     #11 0x56e8a7 in ovn_db_run northd/ovn-northd.c:12932:5
>     #12 0x56d6af in main northd/ovn-northd.c:13338:17
>     #13 0x7f5371d041a2 in __libc_start_main (/lib64/libc.so.6+0x271a2)
> 
> Fixes: 4fdca656857d ("Add ECMP symmetric replies.")
> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
> ---

Please, ignore this one.  Re-sent as part of a patch-set:
https://patchwork.ozlabs.org/project/ovn/list/?series=215674

Best regards, Ilya Maximets.


More information about the dev mailing list