[ovs-dev] [PATCH ovn 00/14] Pack of fixes for memory leaks.

Dumitru Ceara dceara at redhat.com
Fri Nov 20 17:15:15 UTC 2020


On 11/20/20 1:17 AM, Ilya Maximets wrote:
> Found by Clang AddressSanitizer.
> 
> All patches has correct and different 'Fixes' tags, so could be
> backported to appropriate branches.
> 
> Ilya Maximets (14):
>   northd: Fix leaks of strings while formatting ecmp flows.
>   test-ovn: Fix expression leak.
>   actions: Fix leak of child ports in fwd group.
>   actions: Fix leak of select group members.
>   ofctrl: Fix leak of meter mod bands.
>   pinctrl: Fix leak of DNS cache records.
>   ovn-controller: Fix leak of pending ct zones.
>   ovn-nbctl: Fix error leak on duplicated switch port.
>   northd: Fix leak of dynamic string for fwd group ports.
>   actions: Fix leak of dynamic string on fwd group encoding failure.
>   ovn-nbctl: Fix leak of IPs while configuring NAT.
>   ovn-nbctl: Fix IP leak on router NAT addition failure.
>   ovn-nbctl: Fix IP leak on failure of lr policy addition.
>   ovn-nbctl: Fix leak of array of new policies.
> 
>  controller/ofctrl.c         | 1 +
>  controller/ovn-controller.c | 2 +-
>  controller/pinctrl.c        | 6 +++++-
>  lib/actions.c               | 8 ++++++++
>  northd/ovn-northd.c         | 9 ++++++++-
>  tests/test-ovn.c            | 2 +-
>  utilities/ovn-nbctl.c       | 8 +++++++-
>  7 files changed, 31 insertions(+), 5 deletions(-)
> 

Hi Ilya,

Thanks for this!

I only had a minor comment in patch 13/14 but except for that, for the
series:

Acked-by: Dumitru Ceara <dceara at redhat.com>

Thanks,
Dumitru



More information about the dev mailing list