[ovs-dev] [PATCH 4/4] ovsdb-idl: Break into two layers.

[0-day Robot]

Bleep bloop.  Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#47 FILE: lib/ovsdb-cs.c:1:
/* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017 Nicira, Inc.

WARNING: Line is 80 characters long (recommended limit is 79)
#205 FILE: lib/ovsdb-cs.c:159:
    int max_version;            /* Maximum version of monitor request to use. */

WARNING: Comment with 'xxx' marker
#358 FILE: lib/ovsdb-cs.c:312:
 * XXX 'max_version' should ordinarily be 3, to allow use of the most efficient

WARNING: Comment with 'xxx' marker
#633 FILE: lib/ovsdb-cs.c:587:
     * levels. XXX?) */

WARNING: Comment with 'xxx' marker
#1469 FILE: lib/ovsdb-cs.c:1423:
    /* XXX handle failure */

WARNING: Comment with 'xxx' marker
#2007 FILE: lib/ovsdb-cs.c:1961:
        /* XXX return failure? */

WARNING: Line is 80 characters long (recommended limit is 79)
#2274 FILE: lib/ovsdb-cs.c:2228:
                                  "<table-updates%s> is not an object", suffix);

WARNING: Line is 82 characters long (recommended limit is 79)
#2323 FILE: lib/ovsdb-cs.h:1:
/* Copyright (c) 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017 Nicira, Inc.

Lines checked: 5752, Warnings: 8, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot