[ovs-dev] [PATCH branch-2.9 1/2] github: Add GitHub Actions workflow.

[Ilya Maximets]

On 11/26/20 3:02 PM, 0-day Robot wrote:
> Bleep bloop.  Greetings Ilya Maximets, I am a robot and I have tried out your patch.
> Thanks for your contribution.
> 
> I encountered some error that I wasn't expecting.  See the details below.
> 
> 
> build:
> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wno-null-pointer-arithmetic -Werror -Werror   -g -O2 -MT lib/odp-execute.lo -MD -MP -MF $depbase.Tpo -c -o lib/odp-execute.lo lib/odp-execute.c &&\
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT lib/odp-execute.lo -MD -MP -MF lib/.deps/odp-execute.Tpo -c lib/odp-execute.c -o lib/odp-execute.o
> depbase=`echo lib/odp-util.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wno-null-pointer-arithmetic -Werror -Werror   -g -O2 -MT lib/odp-util.lo -MD -MP -MF $depbase.Tpo -c -o lib/odp-util.lo lib/odp-util.c &&\
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wno-null-pointer-arithmetic -Werror -Werror -g -O2 -MT lib/odp-util.lo -MD -MP -MF lib/.deps/odp-util.Tpo -c lib/odp-util.c -o lib/odp-util.o
> lib/odp-util.c: In function 'parse_odp_key_mask_attr':
> lib/odp-util.c:4908:30: error: 'mask_offset' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>              nl_msg_end_nested(mask, mask_offset);                             \
>                               ^
> lib/odp-util.c:4893:28: note: 'mask_offset' was declared here
>          size_t key_offset, mask_offset;                    \
>                             ^
> lib/odp-util.c:5171:5: note: in expansion of macro 'SCAN_BEGIN_NESTED'
>      SCAN_BEGIN_NESTED("tunnel(", OVS_KEY_ATTR_TUNNEL) {
>      ^

That is a false-positive fixed on later branches with commit:
c3013fd3fddb ("odp-util: Keep Address Sanitizer happy.")

Not sure if we need to backport it though.  Thoughts?

TBH, we have some issues on older branches with new compilers,
so maybe it make sense to just disable Werror for these branches
or use older compilers.  It's hard to maintain warning-free builds
for brand new shiny compilers on old branches in general.

Best regards, Ilya Maximets.