[ovs-dev] [PATCH v3] [python] Handle refTable values with setkey()

Ilya Maximets i.maximets at ovn.org
Sat Nov 28 00:01:09 UTC 2020


On 4/30/20 3:51 AM, Terry Wilson wrote:
> Any chance we could get this ( 9435b0b8 ) backported to 2.13 and 2.12 (it
> backported cleanly and passed tests on my box). Thanks!

Hi.  I tried to backport other IDL patch today and there was conflict.
So, I found that this patch was not backported to stable branches.
Backported now to 2.13 and 2.12.

BTW, It might be better to add 'Fixes:' tag for a bug fix, this way it
will be more clear for committer that patch needs a backport.  Follow up
emails sometimes falls through the cracks.

Best regards, Ilya Maximets.

> 
> On Fri, Mar 20, 2020 at 10:48 AM Ben Pfaff <blp at ovn.org> wrote:
> 
>> On Fri, Mar 20, 2020 at 03:22:38PM +0000, Terry Wilson wrote:
>>> For columns like QoS.queues where we have a map containing refTable
>>> values, assigning w/ __setattr__ e.g. qos.queues={1: $queue_row}
>>> works, but using using qos.setkey('queues', 1, $queue_row) results
>>> in an Exception. The opdat argument can essentially just be the
>>> JSON representation of the map column instead of trying to build
>>> it.
>>>
>>> Signed-off-by: Terry Wilson <twilson at redhat.com>
>>
>> Thanks, applied to master.


More information about the dev mailing list