[ovs-dev] [PATCH ovn] lflow.c: Refactor function convert_match_to_expr.
Dumitru Ceara
dceara at redhat.com
Thu Oct 1 11:24:11 UTC 2020
On 10/1/20 12:40 PM, Mark Gray wrote:
> On 01/10/2020 11:37, Dumitru Ceara wrote:
>> On 10/1/20 12:19 PM, Mark Gray wrote:
>>> On 30/09/2020 11:56, Dumitru Ceara wrote:
>
>>>
>>> On failure do we need to undo the flow_resource_add()?
>>>
>>
>> We didn't do before and I think it's fine to leave as is because failure
>> to parse will trigger a recompute of the I-P engine and call
>> en_flow_output_run() which should cleanup the resource refs.
>>
>> Unfortunately I don't see an easier way to do cleanup.
>>
>> I'll send a v2 soon fixing the points above.
>
> Ok, sounds good. Also, I ran the UTs and don't see any issues/failures.
>
v2 available at:
http://patchwork.ozlabs.org/project/ovn/patch/1601551333-25368-1-git-send-email-dceara@redhat.com/
Thanks,
Dumitru
More information about the dev
mailing list