[ovs-dev] [PATCH v3 8/8] appveyor: Bump outdated links and add artifacts

Ilya Maximets i.maximets at ovn.org
Mon Oct 5 14:14:08 UTC 2020


On 10/5/20 2:54 PM, Alin Serdean wrote:
>> *From: *Ilya Maximets <mailto:i.maximets at ovn.org>
> *Sent: *Friday, September 25, 2020 4:55 PM
> *To: *Alin Gabriel Serdean <mailto:aserdean at ovn.org>; ovs-dev at openvswitch.org <mailto:ovs-dev at openvswitch.org>
> *Cc: *i.maximets at ovn.org <mailto:i.maximets at ovn.org>; Yonggang Luo <mailto:luoyonggang at gmail.com>; Jinjun Gao <mailto:jinjung at vmware.com>
> *Subject: *Re: [ovs-dev] [PATCH v3 8/8] appveyor: Bump outdated links and add artifacts
> 
>  
> 
> On 9/24/20 8:24 AM, Alin Gabriel Serdean wrote:
> 
>> Bump OpenSSL.
> 
>>
> 
>> Add release and debug configuration.
> 
>>
> 
>> Build and add Windows installer to generated artifacts.
> 
>>
> 
>> Build and zip prebuilt version.
> 
>>
> 
>> Co-authored-by: Yonggang Luo <luoyonggang at gmail.com>
> 
>> Signed-off-by: Yonggang Luo <luoyonggang at gmail.com>
> 
>> Co-authored-by: Jinjun Gao <jinjung at vmware.com>
> 
>> Signed-off-by: Jinjun Gao <jinjung at vmware.com>
> 
>> Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
> 
>> ---
> 
>  
> 
> Thanks for working on this.  I didn't test the series on Windows,
> 
> but I'm assuming that you did that.  This version does not break
> 
> anything on other systems and the code looks good to me.
> 
>  
> 
> For the series:
> 
>  
> 
> Acked-by: Ilya Maximets <i.maximets at ovn.org>
> 
>  
> 
> [Alin] Thank you for the review! I applied it on master.
> 
>  
> 
> P.S. While this series is good as it is and could be applied, I'd
> 
> still like to update to openssl 1.1.1 if possible in the future.
> 
> If it's not possible for some reason, we should, probably, find a
> 
> way to make it possible.
> 
> [Alin] I’m applying the current series and will send a future
> 
> patch for openssl 1.1.1 when I have a successful unit test run.

OK.  Sounds good.  Thanks!

Best reards, Ilya Maximets.


More information about the dev mailing list