[ovs-dev] OVS-DPDK patch review list

Stokes, Ian ian.stokes at intel.com
Wed Oct 7 20:16:53 UTC 2020


Hi All,

Thanks to all for attending and contributing to today's call. Please see the output from todays weekly patch review session. 

Note the patches listed below represent a merged list of the patches discussed by those attending and as such will be focused on first in order to clear the patch backlog.

Please note reviews are not limited to the patches below and reviews on all patches from the community are welcome.

I can look at creating a google doc so as to have somewhere central to store the list if people prefer.

Patch List

name: travis: Disable check for array of flexible structures in sparse.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=206492
subm: Ilya Maximets (Red Hat)
Why: Required to keep community CI passing.
Status: Needs review
---

name: Some fixes for OVS IPsec on Fedora 
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=205691
subm: Mark Gray (Red Hat)
Why: Simple updates to docs and python installation packages.
Status: Needs review
---

name: New LTS and updated release policy.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=204478
subm: Ilya Maximets (Red Hat)
Why: Need agreement community wide on LTS and branch lifecycle process.
Status: Needs review/feedback.
---

name: ovsdb: Remove read permission of *.db from others
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=203778
subm: Yi-Hung Wei
Why: Possible security concern.
Status: Needs review from deployment perspective rather than technical.
---

name: Use more sensitive terminology.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=188117
subm: Ben Pfaff (OVN)
Why: Multiple communities making similar changes (e.g. DPDK).
Status: Needs review, check if Ben plans on re-working feedback to date otherwise should be worked on by community.
---

name: dpif-netdev: Add miniflow bits to dump-flows.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=176943
subm: William Tu (OVN)
Why: -
Status: Needs review
---

name: system-dpdk: add tso negotiation tests
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=188656
subm: Gowrishankar Muthukrishnan
Why: v8, already acked on some of the series, but more feedback due on numa and memory allocation before applying.
Status: Needs review/testing
---

name: ofproto-dpif-xlate: Do not use zero-weight buckets in select groups.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=112576
subm: Ben Pfaff (OVN)
why?: looks correct, still valid, Ilya validated but no response afterward, get closure.
Status: Needs review.
---

name: travis: Fix kernel download retry.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=165294
subm: David Marchand (Red hat)
why?: Simple CI fix, input was requested to finish the patch, should be short to give.
Status: Needs review/testing.
---

name: ofproto: Fix statistics of datapath operations.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=180758
subm: zhaozhanxu (???)
why?: Error seems simple to fix -- clamp stats down to 0.
Status: Needs review/test
---

name: dpdk: Refuse running on cpu >= RTE_MAX_LCORE.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=185987
subm: David Marchand (Red hat)
why?: This patch is a dependency for another patch supporting new thread API in DPDK.  David did not respond to last remark, just need a follow-up?
Status: Review/testing needed on follow up.
---

name: netdev-offload-dpdk: Pass L4 proto-id to match in the L3 rte_flow_item
href: https://patchwork.ozlabs.org/project/openvswitch/patch/20200710120718.38633-3-sriharsha.basavapatna@broadcom.com/
subm: Sriharsha Basavapatna (Broadcom)
why?: Already acked-by Eli Britstein, fixes rte-flow processing in PMDs, could give an additional pair of eyes.
Status: Review and testing needed, Intel and Broadcom to help.
---

name: tunnel: Set ECN mask bits only when it is matched in the IP header
href: https://patchwork.ozlabs.org/project/openvswitch/patch/20200710120718.38633-4-sriharsha.basavapatna@broadcom.com/
subm: Sriharsha Basavapatna (Broadcom)
why?: Simple patch, get a look at ofproto/tunnel.c, seems fine from a first approach.
Status: Needs review.
---

name: netdev-offload-dpdk: Support vxlan encap offload with load actions
href: https://patchwork.ozlabs.org/project/openvswitch/patch/20200730105838.5329-1-elibr@mellanox.com/
subm: Eli Britstein (Nvidia)
why?: Already reviewed by other nvidia people, can someone take a look pls?
Status: Review and testing needed, Intel and Broadcom to help.
---

name: netdev-offload-dpdk: Preserve HW statistics for modified flows
href: https://patchwork.ozlabs.org/project/openvswitch/patch/20200730135237.22157-1-elibr@mellanox.com/
subm: Eli Britstein (Nvidia)
why?: Already reviewed by me, can someone else take a look?
Status: Needs review/testing.
---

name: netdev-dpdk: support changing VF MAC 
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=202144
subm: Gaetan Rivet (Nvidia)
why?: Latest remarks have been addressed, can someone else take a look?
Status: Further comments planned for review in progress.
---

name: dpctl-netdev: Add the option "pmd" for dump-flows 
href: https://patchwork.ozlabs.org/project/openvswitch/patch/20200928091722.2830-1-xiangxia.m.yue@gmail.com/
subm: Tonghao Zhang (???)
why?: v3, comments might have been fully addressed, simple feature.
Status: Almost reviewed, seems fine, some more review possible, could be applied.


Regards
Ian


More information about the dev mailing list