[ovs-dev] [PATCH] system-userspace-packet-type-aware.at: Wait for ip address updates.

Ilya Maximets i.maximets at ovn.org
Fri Oct 9 15:07:14 UTC 2020


On 9/16/20 8:02 PM, Ilya Maximets wrote:
> ovs-router module checks for the source ip address of the interface
> while adding a new route.  netdev module doesn't request ip addresses
> from the system every time, but instead it caches currently assigned
> ip addresses and updates the cache on netlink notifications if needed.
> 
> So, there is a slight delay between setting ip address on interface
> in a system and a moment OVS updates list of ip addresses of this
> interface.  If route addition happens within this time frame, it
> fails with the following error:
> 
>     # ovs-appctl ovs/route/add 10.0.0.0/24 br-p1
>     Error while inserting route.
>     ovs-appctl: ovs-vswitchd: server returned an error
> 
> This makes system tests to fail frequently.
> 
> Let's wait until local route successfully added.  This will mean
> that OVS finished processing of a netlink event and will use up to
> date list of ip addresses on desired interface.
> 
> Fixes: 526cf4e1d6a8 ("tests: Added unit tests in packet-type-aware.at")
> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
> ---

Thanks, Flavio and Aaron!

Applied to master and backported down to 2.8.

Best regards, Ilya Maximets.


More information about the dev mailing list