[ovs-dev] [PATCH ovs v2] dpctl-netdev: Add the option "pmd" for dump-flows

[Ilya Maximets]

On 10/14/20 4:27 PM, Gaëtan Rivet wrote:
> Hello,
> 
> On 24/07/20 15:33 +0800, xiangxia.m.yue at gmail.com wrote:
>> From: Tonghao Zhang <xiangxia.m.yue at gmail.com>
>>
>> "ovs-appctl dpctl/dump-flows" added the option
>> "pmd" which allow user to dump pmd specified.
>>
>> That option is useful to dump rules of pmd
>> when we have a large number of rules in dp.
>>
> 
> Thanks for the patch! I think it can be useful.
> A few comments below.

Hi Gaëtan,
Thanks for review.  However, since v2 there was 'v2 resend' and v3 of
this patch.  Some comments here are still relevant, but it's better to
review v3 now since it changed significantly.

v2 resend with review comments:
https://patchwork.ozlabs.org/project/openvswitch/patch/20200824024408.56559-1-xiangxia.m.yue@gmail.com/

v3:
https://patchwork.ozlabs.org/project/openvswitch/patch/20200928091722.2830-1-xiangxia.m.yue@gmail.com/

Best regards, Ilya Maximets.