[ovs-dev] [PATCH V4 05/24] datapath: Set OvS recirc_id from tc chain index

Yi-Hung Wei yihung.wei at gmail.com
Wed Oct 14 17:39:42 UTC 2020


On Mon, Oct 12, 2020 at 1:25 PM Greg Rose <gvrose8192 at gmail.com> wrote:
>
> From: Paul Blakey <paulb at mellanox.com>
>
> Upstream commit:
>     commit 95a7233c452a58a4c2310c456c73997853b2ec46
>     Author: Paul Blakey <paulb at mellanox.com>
>     Date:   Wed Sep 4 16:56:37 2019 +0300
>
>     net: openvswitch: Set OvS recirc_id from tc chain index
>
>     Offloaded OvS datapath rules are translated one to one to tc rules,
>     for example the following simplified OvS rule:
>
>     recirc_id(0),in_port(dev1),eth_type(0x0800),ct_state(-trk) actions:ct(),recirc(2)
>
>     Will be translated to the following tc rule:
>
>     $ tc filter add dev dev1 ingress \
>                 prio 1 chain 0 proto ip \
>                     flower tcp ct_state -trk \
>                     action ct pipe \
>                     action goto chain 2
>
>     Received packets will first travel though tc, and if they aren't stolen
>     by it, like in the above rule, they will continue to OvS datapath.
>     Since we already did some actions (action ct in this case) which might
>     modify the packets, and updated action stats, we would like to continue
>     the proccessing with the correct recirc_id in OvS (here recirc_id(2))
>     where we left off.
>
>     To support this, introduce a new skb extension for tc, which
>     will be used for translating tc chain to ovs recirc_id to
>     handle these miss cases. Last tc chain index will be set
>     by tc goto chain action and read by OvS datapath.
>
>     Signed-off-by: Paul Blakey <paulb at mellanox.com>
>     Signed-off-by: Vlad Buslov <vladbu at mellanox.com>
>     Acked-by: Jiri Pirko <jiri at mellanox.com>
>     Acked-by: Pravin B Shelar <pshelar at ovn.org>
>     Signed-off-by: David S. Miller <davem at davemloft.net>
>
> Backport the local datapath changes from this patch and add compat
> layer fixup for the DECLARE_STATIC_KEY_FALSE macro.
>
> Cc: Paul Blakey <paulb at mellanox.com>
> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
>
> ---
> V4 - Add in portion of commit for ovs_dp_cmd_set which was missed
>      in first patch.
> ---

Thanks Greg for this new version. It looks good to me.

Acked-by: Yi-Hung Wei <yihung.wei at gmail.com>


More information about the dev mailing list