[ovs-dev] [PATCH net-next] net: openvswitch: fix to make sure flow_lookup() is not preempted

Eelco Chaudron echaudro at redhat.com
Thu Oct 15 08:11:31 UTC 2020



On 15 Oct 2020, at 9:55, Sebastian Andrzej Siewior wrote:

> On 2020-10-14 12:44:23 [+0200], Eelco Chaudron wrote:
>> Let me know your thoughts.
>
> better. If your seccount is per-CPU then you get away without explicit
> writer locking if you rely on global per-CPU locking. You can't do
> preempt_disable() because this section can be interrupt by softirq. 
> You
> need something stronger :)

Thanks for your reply! Yes I had it replaced with local_bh_disable() in 
my v2, as I noticed the hard IRQ to softirq part earlier.

> Side note: Adding a fixes tag and net-next looks like "stable material
> starting next merge window".

Have the patch on net-next, but will send it out on next (will do the 
conversion later today and sent it out).

Thanks,

Eelco



More information about the dev mailing list