[ovs-dev] [PATCH v4 2/2] Eliminate use of term "slave" in bond, LACP, and bundle contexts.

[0-day Robot]

Bleep bloop.  Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#405 FILE: include/openvswitch/ofp-actions.h:381:
     * member = { members[i] such that weights[i] >= weights[j] for all j != i }

WARNING: Line is 189 characters long (recommended limit is 79)
#2357 FILE: lib/ovs-actions.xml:792:
      <syntax><code>bundle(</code><var>fields</var><code>, </code><var>basis</var><code>, </code><var>algorithm</var><code>, ofport, members:</code><var>port</var>...<code>)</code></syntax>

WARNING: Line is 223 characters long (recommended limit is 79)
#2358 FILE: lib/ovs-actions.xml:793:
      <syntax><code>bundle_load(</code><var>fields</var><code>, </code><var>basis</var><code>, </code><var>algorithm</var><code>, ofport, </code><var>dst</var><code>, members:</code><var>port</var>...<code>)</code></syntax>

WARNING: Line is 155 characters long (recommended limit is 79)
#2396 FILE: lib/ovs-actions.xml:871:
<var>member</var> = { <var>i</var> such that <var>weights</var>[<var>i</var>] >= <var>weights</var>[<var>j</var>] for all <var>j</var> != <var>i</var> }

WARNING: Line is 81 characters long (recommended limit is 79)
#2614 FILE: ofproto/bond.c:168:
static struct bond_member *bond_member_lookup(struct bond *, const void *member_)

WARNING: Line is 82 characters long (recommended limit is 79)
#2836 FILE: ofproto/bond.c:583:
        hmap_insert(&bond->members, &member->hmap_node, hash_pointer(member_, 0));

WARNING: Line is 80 characters long (recommended limit is 79)
#3120 FILE: ofproto/bond.c:870:
        verdict = (member->enabled || member->may_enable) ? BV_ACCEPT : BV_DROP;

WARNING: Comment with 'xxx' marker
#3419 FILE: ofproto/bond.c:1288:
     * XXX This is O(n**2) in the number of members but it could be O(n lg n)

WARNING: Line is 80 characters long (recommended limit is 79)
#3457 FILE: ofproto/bond.c:1323:
             * 'e' to be migrated to another member in this rebalancing run, and

WARNING: Line is 80 characters long (recommended limit is 79)
#3843 FILE: ofproto/bond.c:1822:
            ovs_list_insert(&member->bond->enabled_members, &member->list_node);

WARNING: Line is 80 characters long (recommended limit is 79)
#4208 FILE: ofproto/bond.h:123:
 *  recirc_id=<bond_recirc_id>, dp_hash=<[0..255]>/0xff, actions: output<member>

WARNING: Line is 80 characters long (recommended limit is 79)
#4417 FILE: ofproto/ofproto-dpif.c:3565:
            bond_member_set_may_enable(bundle->bond, port, port->up.may_enable);

WARNING: Line is 80 characters long (recommended limit is 79)
#4510 FILE: ofproto/ofproto-provider.h:1712:
     * and, if there is more than one member, a bonding configuration.  If 'aux'

WARNING: Line is 81 characters long (recommended limit is 79)
#4575 FILE: ofproto/ofproto.h:459:
    struct lacp_member_settings *lacp_members; /* Array of n_members elements. */

Lines checked: 6143, Warnings: 14, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot