[ovs-dev] OVS-DPDK patch review list update

[Stokes, Ian]

Hi All,

Please see the updated patch review list from this weeks call. Note we've tried to allocate patches under headers to indicate which patches could use attention (e.g. those close to merging or those already under review could be focused on so as to close off the patch).

Regards
Ian

Patch List

=== Merged ===
name: travis: Disable check for array of flexible structures in sparse.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=206492
subm: Ilya Maximets (Red Hat)
Why: Required to keep community CI passing.
Status: Merged


=== Merge Candidate (Close to merging) ===

name: ovsdb: Remove read permission of *.db from others
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=203778
subm: Yi-Hung Wei
Why: Possible security concern.
Status: Needs review from deployment perspective rather than technical. Acked by Red Hat, will wait for anymore feedback in the next few days before merge.

name: travis: Fix kernel download retry.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=165294
subm: David Marchand (Red hat)
why?: Simple CI fix, input was requested to finish the patch, should be short to give.
Status: Reviewed. Acked by Red Hat.

name: netdev-offload-dpdk: Support vxlan encap offload with load actions
href: https://patchwork.ozlabs.org/project/openvswitch/patch/20200730105838.5329-1-elibr@mellanox.com/
subm: Eli Britstein (Nvidia)
why?: Already reviewed by other nvidia people, can someone take a look pls?
Status: Broadcom acked, Intel validated. Ilya to provide feedback.

name: netdev-offload-dpdk: Preserve HW statistics for modified flows
href: https://patchwork.ozlabs.org/project/openvswitch/patch/20201012142735.5304-1-elibr@nvidia.com/
subm: Eli Britstein (Nvidia)
why?: Already reviewed by me, can someone else take a look?
Status: Broadcom acked, Intel validated.


=== Review In Progress ===

name: New LTS and updated release policy.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=204478
subm: Ilya Maximets (Red Hat)
Why: Need agreement community wide on LTS and branch lifecycle process.
Status: Needs review/feedback.
---

name: Use more sensitive terminology.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=208454
subm: Ben Pfaff (OVN)
Why: Multiple communities making similar changes (e.g. DPDK).
Status: Some patches merged, v4 sent for remaining patches, requires review.
---

name: ofproto-dpif-xlate: Do not use zero-weight buckets in select groups.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=112576
subm: Ben Pfaff (OVN)
why?: looks correct, still valid, Ilya validated but no response afterward, get closure.
Status: Needs review and rebase but close to merging.
---

name: ofproto: Fix statistics of datapath operations.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=180758
subm: zhaozhanxu (???)
why?: Error seems simple to fix -- clamp stats down to 0.
Status: Needs review/test, Ian acked but reproduction of the issue seems difficult/unlikely (Ilya), awaiting from zhaozhanxu on where/when the issue is seen.
---

name: dpdk: Refuse running on cpu >= RTE_MAX_LCORE.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=185987
subm: David Marchand (Red hat)
why?: This patch is a dependency for another patch supporting new thread API in DPDK.  David did not respond to last remark, just need a follow-up?
Status: Review/testing needed on follow up. Kevin looked at patch, David will send new patch.
---

name: netdev-offload-dpdk: Pass L4 proto-id to match in the L3 rte_flow_item
href: https://patchwork.ozlabs.org/project/openvswitch/patch/20200710120718.38633-3-sriharsha.basavapatna@broadcom.com/
subm: Sriharsha Basavapatna (Broadcom)
why?: Already acked-by Eli Britstein, fixes rte-flow processing in PMDs, could give an additional pair of eyes.
Status: Nvidia acked, Intel to review.
---

name: tunnel: Set ECN mask bits only when it is matched in the IP header
href: https://patchwork.ozlabs.org/project/openvswitch/patch/20200710120718.38633-4-sriharsha.basavapatna@broadcom.com/
subm: Sriharsha Basavapatna (Broadcom)
why?: Simple patch, get a look at ofproto/tunnel.c, seems fine from a first approach.
Status: Needs review. Mark Gray reviewed, a patch did not apply, outstanding comments required + rebase.
---

name: netdev-offload-dpdk: Support vxlan encap offload with load actions
href: https://patchwork.ozlabs.org/project/openvswitch/patch/20200730105838.5329-1-elibr@mellanox.com/
subm: Eli Britstein (Nvidia)
why?: Already reviewed by other nvidia people, can someone take a look pls?
Status: Review and testing needed, Intel and Broadcom to help. Broadcom Acked, Intel validated, Ilya to provide feedback.
---

name: netdev-offload-dpdk: Preserve HW statistics for modified flows
href: https://patchwork.ozlabs.org/project/openvswitch/patch/20200730135237.22157-1-elibr@mellanox.com/
subm: Eli Britstein (Nvidia)
why?: Already reviewed by me, can someone else take a look?
Status: Needs review/testing. Intel validated, Broadcom acked later revision of this patch (patch link to be updated).
---

name: netdev-dpdk: support changing VF MAC 
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=202144
subm: Gaetan Rivet (Nvidia)
why?: Latest remarks have been addressed, can someone else take a look?
Status: Further comments planned for review in progress. Kevin review in progress, will provide comments.
---

name: dpctl-netdev: Add the option "pmd" for dump-flows 
href: https://patchwork.ozlabs.org/project/openvswitch/patch/20200928091722.2830-1-xiangxia.m.yue@gmail.com/
subm: Tonghao Zhang (???)
why?: v3, comments might have been fully addressed, simple feature.
Status: Almost reviewed, seems fine, some more review possible, could be applied. Nvidia providing comments to be addressed.


=== Not Reviewed (No review in progress) ===

name: Some fixes for OVS IPsec on Fedora 
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=205691
subm: Mark Gray (Red Hat)
Why: Simple updates to docs and python installation packages.
Status: Needs review

name: dpif-netdev: Add miniflow bits to dump-flows.
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=176943
subm: William Tu (OVN)
Why: -
Status: Needs review. Ian to follow up with William.
---

name: system-dpdk: add tso negotiation tests
href: https://patchwork.ozlabs.org/project/openvswitch/list/?series=188656
subm: Gowrishankar Muthukrishnan
Why: v8, already acked on some of the series, but more feedback due on numa and memory allocation before applying.
Status: Needs review/testing.