[ovs-dev] [PATCH 2/2] odp-util: Add missing comma after gtpu attributes.

Ilya Maximets i.maximets at ovn.org
Mon Oct 19 18:23:52 UTC 2020


Currently flows are printed like this:
        'tunnel(gtpu(flags=0x7f,msgtype=0)flags(0))'
With this change:
        'tunnel(gtpu(flags=0x7f,msgtype=0),flags(0))'

Fixes: 3c6d05a02e0f ("userspace: Add GTP-U support.")
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
---
 lib/odp-util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/odp-util.c b/lib/odp-util.c
index e7424a9ac..0bd2f9aa8 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -3971,7 +3971,7 @@ format_odp_tun_attr(const struct nlattr *attr, const struct nlattr *mask_attr,
         case OVS_TUNNEL_KEY_ATTR_GTPU_OPTS:
             ds_put_cstr(ds, "gtpu(");
             format_odp_tun_gtpu_opt(a, ma, ds, verbose);
-            ds_put_cstr(ds, ")");
+            ds_put_cstr(ds, "),");
             break;
         case __OVS_TUNNEL_KEY_ATTR_MAX:
         default:
-- 
2.25.4



More information about the dev mailing list