[ovs-dev] 答复: [PATCH 2/2] odp-util: Add missing comma after gtpu attributes.

Yi Yang (杨燚)-云服务集团 yangyi01 at inspur.com
Tue Oct 20 01:28:16 UTC 2020


Acked-by: Yi Yang <yangyi01 at inspur.com>

-----邮件原件-----
发件人: Ilya Maximets [mailto:i.maximets at ovn.org] 
发送时间: 2020年10月20日 2:24
收件人: ovs-dev at openvswitch.org
抄送: William Tu <u9012063 at gmail.com>; Yi Yang (杨燚)-云服务集团 <yangyi01 at inspur.com>; Ilya Maximets <i.maximets at ovn.org>
主题: [PATCH 2/2] odp-util: Add missing comma after gtpu attributes.

Currently flows are printed like this:
        'tunnel(gtpu(flags=0x7f,msgtype=0)flags(0))'
With this change:
        'tunnel(gtpu(flags=0x7f,msgtype=0),flags(0))'

Fixes: 3c6d05a02e0f ("userspace: Add GTP-U support.")
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
---
 lib/odp-util.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/odp-util.c b/lib/odp-util.c index e7424a9ac..0bd2f9aa8 100644
--- a/lib/odp-util.c
+++ b/lib/odp-util.c
@@ -3971,7 +3971,7 @@ format_odp_tun_attr(const struct nlattr *attr, const struct nlattr *mask_attr,
         case OVS_TUNNEL_KEY_ATTR_GTPU_OPTS:
             ds_put_cstr(ds, "gtpu(");
             format_odp_tun_gtpu_opt(a, ma, ds, verbose);
-            ds_put_cstr(ds, ")");
+            ds_put_cstr(ds, "),");
             break;
         case __OVS_TUNNEL_KEY_ATTR_MAX:
         default:
--
2.25.4



More information about the dev mailing list