[ovs-dev] [PATCH dpdk-latest 0/3] Revert DPDK 20.05/20.08 sparse commits

Ilya Maximets i.maximets at ovn.org
Wed Oct 21 08:56:21 UTC 2020


On 10/21/20 10:34 AM, David Marchand wrote:
> On Wed, Oct 21, 2020 at 9:48 AM Eli Britstein <elibr at nvidia.com> wrote:
>>
>> With DPDK 20.11-rc1, travis fails. Reverting the commits that were done
>> for DPDK 20.05/20.08 fixes it.
>>
>> Note: maybe we can avoid merging them to master instead of applying and
>> reverting.
>>
>> Travis:
>> https://travis-ci.org/github/elibritstein/OVS/builds/737627018
> 
> This is due to yesterday changes in sparse:
> https://git.kernel.org/pub/scm/devel/sparse/sparse.git/commit/?id=cf8f104749f5bca36852989297af8cc19ff24d5f
> 
> I'd rather keep those wrappers in OVS if someone is still using a
> previous version of sparse.
> We can simply test if __ATOMIC_* is already defined.

If that is the only reason then it's better to just wrap the definitions in
'ifndef', so stable versions of Sparse will work.  I agree.

Best regards, Ilya Maximets.


More information about the dev mailing list