[ovs-dev] [PATCH] raft: Fix error leak on failure while saving snapshot.
Ilya Maximets
i.maximets at ovn.org
Fri Oct 23 18:30:10 UTC 2020
Error should be destroyed before return.
Fixes: 1b1d2e6daa56 ("ovsdb: Introduce experimental support for clustered databases.")
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
---
ovsdb/raft.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ovsdb/raft.c b/ovsdb/raft.c
index 708b0624c..816f69e22 100644
--- a/ovsdb/raft.c
+++ b/ovsdb/raft.c
@@ -3986,7 +3986,7 @@ raft_handle_install_snapshot_request__(
struct ovsdb_error *error = raft_save_snapshot(raft, new_log_start,
&new_snapshot);
if (error) {
- char *error_s = ovsdb_error_to_string(error);
+ char *error_s = ovsdb_error_to_string_free(error);
VLOG_WARN("could not save snapshot: %s", error_s);
free(error_s);
return false;
--
2.25.4
More information about the dev
mailing list