[ovs-dev] [PATCH v2] net: openvswitch: pass NULL for unused parameters

Tom Rix trix at redhat.com
Wed Sep 2 18:40:10 UTC 2020


On 9/1/20 1:11 PM, David Miller wrote:
> From: trix at redhat.com
> Date: Sun, 30 Aug 2020 14:26:30 -0700
>
>> Passing unused parameters is a waste.
> Poorly predicted branches are an even bigger waste.
>
> I'm not a big fan of this change and others have asked for performance
> analysis to be performed.
>
> So I'm not applying this as-is, sorry.

no worries.

I think these functions need a larger working over so the stats collecting are not in the core functions.

Thanks for giving it a look,

Tom

>
> It's also not great to see that CLANG can't make use of the caller's
> __always_unused directive to guide these warnings.



More information about the dev mailing list