[ovs-dev] [PATCH v4 1/3] id-pool: Add interface to check if id has been allocated

[Mark Gray]

On 01/09/2020 16:10, Flavio Leitner wrote:
> 
> Hi Mark,
> 
> Sort of nitpicking but looks like making id_pool_find()
> public would be better because I don't know what is
> being checked in the new function. 
> 
> The new function is a simple wrapper around _find()
> and to me either _find() or _lookup() names translate
> better to what is being done.
> 
> What do you think?
> 
> fbl
> 

It's not nitpicking :D I did think of that but id_pool_find() returns a
private object (id_node) so I'd have to expose that, breaking the
encapsulation of id-pool which I didn't want to do.

Perhaps I could change the public name to _lookup() or something like
id_pool_is_id_avail()?

Mark