[ovs-dev] [PATCH v4 3/3] AUTHORS: Update email address
Mark Gray
mark.d.gray at redhat.com
Fri Sep 4 14:38:57 UTC 2020
On 04/09/2020 14:23, Ilya Maximets wrote:
> On 8/28/20 7:03 PM, Mark Gray wrote:
>> Signed-off-by: Mark Gray <mark.d.gray at redhat.com>
>> ---
Posted a v5 and just saw this now :( Thanks for the feedback.
>
> Maybe you also want to update .mailmap?
> So git will know your correct e-mail address. For 'git blame' purposes. :)
I didn't know about mailmap so happy to do this.
>
> It also make sense to send this patch separately (not as part of a patch set)
> and have a bit more meaningful patch subject, e.g. have your name in it (this
> just simplifies automatic patch detection since there are already a bunch of
> equally named patches in patchwork).
Sure thing, I will redo in v6
>
> And since we're here, it's usually better to have a cover letter while sending
> patch-sets with more than one patch.
> And, yes, as Flavio already mentioned, please, don't send new versions in reply
> to old ones.
Yeah, it was a weird one because it didn't have a cover letter initially
as it was one patch. However, I can redo this in v6.
>
> Best regards, Ilya Maximets.
>
>> AUTHORS.rst | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/AUTHORS.rst b/AUTHORS.rst
>> index 4d8eaa3bd..cb26e0197 100644
>> --- a/AUTHORS.rst
>> +++ b/AUTHORS.rst
>> @@ -255,7 +255,7 @@ Madhu Challa challa at noironetworks.com
>> Manohar K C manukc at gmail.com
>> Marcin Mirecki mmirecki at redhat.com
>> Mario Cabrera mario.cabrera at hpe.com
>> -Mark D. Gray mark.d.gray at intel.com
>> +Mark D. Gray mark.d.gray at redhat.com
>> Mark Hamilton
>> Mark Kavanagh mark.b.kavanagh81 at gmail.com
>> Mark Maglana mmaglana at gmail.com
>>
>
More information about the dev
mailing list